Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong date depending on timezone #668

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix: wrong date depending on timezone #668

merged 1 commit into from
Oct 11, 2024

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Oct 11, 2024

Depending on timezone, current time might lead to one day before or one day after the from / to selection. This leads to strange behaviours of the range picker. See recording:

Screen.Recording.2024-10-10.at.9.29.30.AM.mov

Test: https://timezone-issue--helix-website--adobe.aem.live/tools/rum/explorer.html?domain=blog.adobe.com&filter=&view=custom&startDate=2024-10-07&endDate=2024-10-08&userAgent=desktop&checkpoint=click&domainkey=incognito

Test requires to change the computer timezone.

Copy link

aem-code-sync bot commented Oct 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@kptdobe kptdobe requested a review from trieloff October 11, 2024 08:48
@kptdobe kptdobe merged commit a03a8fb into main Oct 11, 2024
3 of 4 checks passed
@kptdobe kptdobe deleted the timezone-issue branch October 11, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant